Something-driven development

Software development thoughts around Ubuntu, Python, Golang and other tools

Code-reviews as relationship builders

with 2 comments

I really enjoyed the emphasis of Ben’s Code-reviews as relationship builders post over the weekend. The focus on healthy learning relationships both for new and old is great – something I’ve tried to focus on myself over the past few years working in distributed teams.

On a related note, I’ve wondered of late whether I could use “Agreed” rather than “Approved” when reviewing a branch. Agreed (IMO) implies one type of relationship – peer discussion resulting in agreement – rather than an approval from an authority (perhaps without interaction). It is a small and maybe insignificant distinction…

About these ads

Written by Michael

March 22, 2011 at 11:27 am

Posted in Uncategorized

2 Responses

Subscribe to comments with RSS.

  1. I don’t think the distinction is all that insignificant. Certainly something to consider.

    We’ve run into the same thing with code review for the “Rejected” status. Which we almost never use, because it sounds quite harsh. Things tended to end up in huge “Work-In-Progress” lists, because while we weren’t happy with the current implementation, we didn’t want to “Reject” the idea.

    John

    March 25, 2011 at 11:19 am

  2. True – I tend to use either “Needs information” or if it’s obviously broken “Needs fixing”. Normally (in my experience), it’s the person who submitted the MP who ‘rejects’ it if need be… (in which case, they’re really withdrawing it from discussion/consideration).

    Michael

    March 25, 2011 at 12:58 pm


Leave a Reply

Fill in your details below or click an icon to log in:

WordPress.com Logo

You are commenting using your WordPress.com account. Log Out / Change )

Twitter picture

You are commenting using your Twitter account. Log Out / Change )

Facebook photo

You are commenting using your Facebook account. Log Out / Change )

Google+ photo

You are commenting using your Google+ account. Log Out / Change )

Connecting to %s

Follow

Get every new post delivered to your Inbox.

Join 84 other followers

%d bloggers like this: